Fix messaging for data processing changes #983
Conversation
📦 Next.js Bundle Analysis for uiThis analysis was generated by the Next.js Bundle Analysis action. 🤖 One Page Changed SizeThe following page changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #983 +/- ##
==========================================
- Coverage 85.21% 85.19% -0.02%
==========================================
Files 548 548
Lines 10083 10085 +2
Branches 2175 2177 +2
==========================================
Hits 8592 8592
- Misses 1431 1433 +2
Partials 60 60 ☔ View full report in Codecov by Sentry. |
| !(changedQCFilters.size === 1 && changedQCFilters.has('embeddingSettings')) | ||
| && ( | ||
| <Alert | ||
| message='Note that you will lose your previous Louvain or Leiden clusters.' |
There was a problem hiding this comment.
@ogibson -- you will also lose custom cell sets, automatically annotated cell sets, etc
please have a bioinformatician review changes like this
There was a problem hiding this comment.
I did double check this specifically for custom cell sets and verified that we weren't losing them. Haven't checked for automatically annotated cell sets yet.
There was a problem hiding this comment.
The issue came up when trying to merge this to our fork. Martin pointed out that we weren't actually losing all cell sets and he specifically asked for this change (also to fix the fact that running embedding doesn't remove annotations).
There was a problem hiding this comment.
Automatically annotated cellsets aren't lost either. Not when rerunning clustering nor when changing QC settings.
There was a problem hiding this comment.
Yes but this warning is for any changes to QC -- I agree we could differentiate but it would get complicated:
- only embedding (UMAP vs TSNE) settings --> lose nothing
- only changing clustering settings --> lose louvain/leiden clustering only
- changing anything else in QC --> lose all annotations
I think until we implement this complicated logic for whether to show a warning, the cautionary principle is best (more likely to be upset if lose annotations and didn't know that would -- probably won't care if told that would lose annotations and didn't)
There was a problem hiding this comment.
I tested changing other settings in QC, and you still don't lose annotations (only louvain clusters).
There was a problem hiding this comment.
I also thought we would lose them, but I believe this was changed at some point.
There was a problem hiding this comment.
Ahh nice! Could have swarn I checked that but happy to be wrong -- apologies for the misunderstanding :)
Description
Details
URL to issue
N/A
Link to staging deployment URL (or set N/A)
N/A
Links to any PRs or resources related to this PR
Integration test branch
master
Merge checklist
Your changes will be ready for merging after all of the steps below have been completed.
Code updates
Have best practices and ongoing refactors being observed in this PR
Manual/unit testing
Integration testing
You must check the box below to run integration tests on the latest commit on your PR branch.
Integration tests have to pass before the PR can be merged. Without checking the box, your PR
will not pass the required status checks for merging.
Documentation updates
Optional